Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: github sponsors #1725

Merged
merged 3 commits into from
Sep 8, 2022
Merged

fix: github sponsors #1725

merged 3 commits into from
Sep 8, 2022

Conversation

eddiejaoude
Copy link
Member

@eddiejaoude eddiejaoude commented Sep 5, 2022

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added small Pull request with less than 10 changed lines waiting-for-reviewers chore: profile-adition labels Sep 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Reviewpad Report

ℹ️ Messages

  • A maintainer will review your pull request soon!

@github-actions github-actions bot added the LGTM label Sep 5, 2022
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Eddie, LinkFree also has dollar icon. I think it fits well. What are your thoughts?

public/data/eddiejaoude.json Show resolved Hide resolved
eddiejaoude and others added 2 commits September 5, 2022 21:03
Co-authored-by: Pradumna Saraf <pradumnasaraf@gmail.com>
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

__
sema-logo  Summary: 👌 This code looks good  |  Tags: Elegant

},
{
"name": "Customising your GitHub Profile course (free)",
"url": "http://eddiejaoude.io/course-github-profile-landing",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's using the secure extension, so I believe we should update it!!

Suggested change
"url": "http://eddiejaoude.io/course-github-profile-landing",
"url": "https://eddiejaoude.io/course-github-profile-landing",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, but the link is without https and it redirects to the https on a sub domain

@eddiejaoude eddiejaoude merged commit 526a22f into main Sep 8, 2022
@eddiejaoude eddiejaoude deleted the eddiejaoude-patch-3 branch September 8, 2022 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⭐ goal: addition undefined LGTM small Pull request with less than 10 changed lines waiting-for-reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants