-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Conversation
Welcome @Manmohan11! Thank you so much for your first pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
@eddiejaoude please review this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert changes to the package-lock file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
note: the package-lock.json
should not be committed
@eddiejaoude @EmmaDawsonDev please review, I've reverted changes made into package-lock.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
closes #1937
Fixes Issue
shortcut key for searchbox
Changes proposed
Made changes in Home.js & Searchbar.js
Check List (Check all the applicable boxes)
Note to reviewers
On main page shortcut key 'ctrl+k' takes us to the search box.