Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

keyboard shortcut added for seachbox #1971

Merged
merged 3 commits into from
Oct 21, 2022
Merged

keyboard shortcut added for seachbox #1971

merged 3 commits into from
Oct 21, 2022

Conversation

Manmohan11
Copy link
Contributor

@Manmohan11 Manmohan11 commented Oct 14, 2022

closes #1937

Fixes Issue

shortcut key for searchbox

Changes proposed

Made changes in Home.js & Searchbar.js

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Note to reviewers

On main page shortcut key 'ctrl+k' takes us to the search box.

@github-actions github-actions bot added the large Pull request with more than 30 changed lines label Oct 14, 2022
@github-actions
Copy link
Contributor

Welcome @Manmohan11! Thank you so much for your first pull request!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@Manmohan11
Copy link
Contributor Author

@eddiejaoude please review this pr
I've made relavent changes
everything is working fine on local

Copy link
Member

@EmmaDawsonDev EmmaDawsonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes to the package-lock file.

eddiejaoude
eddiejaoude previously approved these changes Oct 16, 2022
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

note: the package-lock.json should not be committed

@eddiejaoude eddiejaoude dismissed their stale review October 16, 2022 21:10

changes required

@github-actions github-actions bot added the medium Pull request with changed lines between 10 and 30 label Oct 17, 2022
@Manmohan11
Copy link
Contributor Author

Manmohan11 commented Oct 17, 2022

@eddiejaoude @EmmaDawsonDev please review, I've reverted changes made into package-lock.json

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@eddiejaoude eddiejaoude merged commit 2eda13a into EddieHubCommunity:main Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
large Pull request with more than 30 changed lines medium Pull request with changed lines between 10 and 30 waiting-for-reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER]-keyboard shortcut for seachbox
3 participants