Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[ Improvement ] Adding Max-width to Links Bar #208

Closed
rohan-kulkarni-25 opened this issue Sep 16, 2021 · 5 comments · Fixed by #209
Closed

[ Improvement ] Adding Max-width to Links Bar #208

rohan-kulkarni-25 opened this issue Sep 16, 2021 · 5 comments · Fixed by #209
Labels
💻 aspect: code undefined ✨ goal: improvement undefined Hacktoberfest Good issues for Hacktoberfest participants 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@rohan-kulkarni-25
Copy link
Member

When we see the links of profile in full screen the width don't look good. We can add a property max width so the width will not go beyond that and will be responsive also

image

I will like to fix it
@github-actions
Copy link
Contributor

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@rohan-kulkarni-25 rohan-kulkarni-25 mentioned this issue Sep 16, 2021
Merged
@schmelto schmelto added Hacktoberfest Good issues for Hacktoberfest participants ✨ goal: improvement undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) 💻 aspect: code undefined labels Sep 16, 2021
@technophile-04
Copy link

can i try to fix this ??

@FayasNoushad
Copy link
Contributor

can i try to fix this ??

@rohan-kulkarni-25 adding that.

@technophile-04
Copy link

ohh ok so its already taken

@rohan-kulkarni-25
Copy link
Member Author

ohh ok so its already taken

Yes actually PR #209 is for this issue

eddiejaoude added a commit that referenced this issue Sep 26, 2021
@rohan-kulkarni-25 @eddiejaoude
fix: links width (#208)
9f11c54 
Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💻 aspect: code undefined ✨ goal: improvement undefined Hacktoberfest Good issues for Hacktoberfest participants 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvement : Added maxwidth property to link bar rohan-kulkarni-25/LinkFree
4 participants
@schmelto @rohan-kulkarni-25 @FayasNoushad @technophile-04