This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
[Updated] UserTestimonial.js | Solved Issue #2444 #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
github-actions
bot
added
the
medium
eddiejaoude
reviewed
Dec 27, 2022
eddiejaoude
reviewed
Dec 27, 2022
eddiejaoude
suggested changes
Dec 27, 2022
|
@adityassharma-ss thank you for requesting a review from me. Please see my inline comments first |
eddiejaoude
reviewed
Dec 28, 2022
eddiejaoude
reviewed
Dec 28, 2022
| alt={testimonial.username} | ||
| className="h-20 w-20 rounded-full bg-gray-100" | ||
| /> | ||
| <a href={testimonial.url} target="_blank" rel="noreferrer"> |
eddiejaoude
reviewed
Dec 28, 2022
components/user/UserTestimonials.js
Outdated
| @@ -51,4 +44,4 @@ export default function UserTestimonials({ users, data, BASE_URL }) { | |||
| ))} | |||
| </> | |||
| ); | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Ending blank line is needed at the end of the file (indicate by GitHub by red icon)
There was a problem hiding this comment.
Yeah! sure. Done.
eddiejaoude
suggested changes
Dec 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the user testimonials.js file & added a feature solving the issue #2444. You can review it accordingly.
Fixes Issue
Closes #2444
Changes proposed
Check List (Check all the applicable boxes)
[ X ] My code follows the code style of this project.
[ X ] My change requires changes to the documentation.
[ X ] I have updated the documentation accordingly.
[ X ] All new and existing tests passed.
[ X ] This PR does not contain plagiarized content.
[ X ] The title of my pull request is a short description of the requested changes.
Note to reviewers
I have reviewed all the changes & the update feature works fine. So you can add it to the deployment without any hesitation.