Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: licence year #3683

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix: licence year #3683

merged 1 commit into from
Jan 20, 2023

Conversation

PerkinsDan
Copy link
Contributor

@PerkinsDan PerkinsDan commented Jan 19, 2023

Fixes Issue

Closes #2834

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions github-actions bot added the small Pull request with less than 10 changed lines label Jan 19, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I also think it should be 2021-2023 or the year of the creation, i.e 2021

Tagging @eddiejaoude for their thoughts and decisions.

Copy link
Member

@SaraJaoude SaraJaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my research it appears that the year should be the first year in which the work was first carried out.

Whilst a range of years is not strictly necessary, this seems to be common practice for many.

I will approve these changes and merge

@SaraJaoude SaraJaoude merged commit 0f4bbee into EddieHubCommunity:main Jan 20, 2023
@Pradumnasaraf
Copy link
Contributor

From my research it appears that the year should be the first year in which the work was first carried out.

Whilst a range of years is not strictly necessary, this seems to be common practice for many.

I will approve these changes and merge

Yes, agree. That is why I mentioned above that it should be 2021-2023 or 2021

Thanks for checking

@PerkinsDan PerkinsDan deleted the licence branch January 20, 2023 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📄 aspect: text undefined small Pull request with less than 10 changed lines waiting-for-reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 2023 to license
4 participants