Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: refactor badges to component #4479

Merged
merged 6 commits into from
Feb 12, 2023
Merged

fix: refactor badges to component #4479

merged 6 commits into from
Feb 12, 2023

Conversation

eddiejaoude
Copy link
Member

@eddiejaoude eddiejaoude commented Feb 5, 2023

Fixes Issue

No visual changes (some minor) but this PR is to standardise using badges across the platform with a reusable Badge component

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added the large Pull request with more than 30 changed lines label Feb 5, 2023
@github-actions github-actions bot added the ✍ chore: profile This label will be added on PR with request of Data json addition label Feb 5, 2023
@eddiejaoude eddiejaoude removed the ✍ chore: profile This label will be added on PR with request of Data json addition label Feb 9, 2023
@github-actions github-actions bot added the ✍ chore: profile This label will be added on PR with request of Data json addition label Feb 11, 2023
@eddiejaoude eddiejaoude marked this pull request as ready for review February 11, 2023 08:12
@eddiejaoude eddiejaoude added 🤖 aspect: dx undefined and removed ✍ chore: profile This label will be added on PR with request of Data json addition labels Feb 11, 2023
@github-actions github-actions bot added the ✍ chore: profile This label will be added on PR with request of Data json addition label Feb 11, 2023
@eddiejaoude eddiejaoude merged commit 9fb02a0 into main Feb 12, 2023
@eddiejaoude eddiejaoude deleted the badge-component branch February 12, 2023 15:55
@ThePiyushAggarwal
Copy link

I think this PR closes #2250

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx undefined ✍ chore: profile This label will be added on PR with request of Data json addition large Pull request with more than 30 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants