Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

add ravireddy07 #510

Merged
merged 6 commits into from
Oct 14, 2021
Merged

add ravireddy07 #510

merged 6 commits into from
Oct 14, 2021

Conversation

ravireddy07
Copy link
Contributor

@ravireddy07 ravireddy07 commented Oct 13, 2021

Description:

I would like to add my profile to the LinkFree.

Changes:

I've added a new file ravireddy07.json under public/data with necessary data.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@schmelto schmelto added the ✍ chore: profile This label will be added on PR with request of Data json addition label Oct 13, 2021
@schmelto schmelto changed the title My Profile Added add ravireddy07 Oct 13, 2021
@schmelto
Copy link
Contributor

image

public/data/ravireddy07.json Outdated Show resolved Hide resolved
public/data/ravireddy07.json Outdated Show resolved Hide resolved
public/data/ravireddy07.json Outdated Show resolved Hide resolved
@schmelto
Copy link
Contributor

Above mentioned changes will add
image

@ravireddy07
Copy link
Contributor Author

Above mentioned changes will add image

Thanks,
Updated and added few more milestones.

@ravireddy07 ravireddy07 requested a review from schmelto October 13, 2021 12:40
@schmelto
Copy link
Contributor

Of you don't want to add a URL for every milestone you can wait for #511 to be merged

Copy link
Contributor

@schmelto schmelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

public/data/ravireddy07.json Outdated Show resolved Hide resolved
public/data/ravireddy07.json Outdated Show resolved Hide resolved
public/data/ravireddy07.json Outdated Show resolved Hide resolved
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments by @krishguptadev.

schmelto and others added 2 commits October 14, 2021 14:23
Co-authored-by: Krish Gupta <krishguptadev@outlook.com>
Co-authored-by: Krish Gupta <krishguptadev@outlook.com>
@schmelto schmelto merged commit 4fbd43b into EddieHubCommunity:main Oct 14, 2021
@ravireddy07
Copy link
Contributor Author

Ohh, I was about to update the requested changes. Sorry for the delay.

"target": "https://github.com/ravireddy07"
}
]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing an endline.

Suggested change
}

@eddiejaoude
Copy link
Member

Great collaboration everyone 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants