Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Side margins are not consistent. #620

Closed
Pradumnasaraf opened this issue Oct 29, 2021 · 9 comments · Fixed by #625
Closed

Side margins are not consistent. #620

Pradumnasaraf opened this issue Oct 29, 2021 · 9 comments · Fixed by #625
Assignees
@mohan-murali
Labels
🛠 goal: fix undefined 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@Pradumnasaraf
Copy link
Contributor

Pradumnasaraf commented Oct 29, 2021 •
edited
Loading

Description

Side margins on the landing page are not consistent, even though the page is at 100%.

The problem arises in :

  • PC
  • Mobile
  • Mobile with Desktop site enabled.

Screenshots

PC

Screenshot 2021-10-29 181305

Mobile

Mobile with Desktop site enabled

Additional information

It may vary from one screen size to another
@Pradumnasaraf Pradumnasaraf added the 🛠 goal: fix undefined label Oct 29, 2021
@github-actions
Copy link
Contributor

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@FidalMathew
Copy link
Member

@Pradumnasaraf I would like to work on this issue. I hope no one is working on it.

@Pradumnasaraf
Copy link
Contributor Author

Pradumnasaraf commented Nov 1, 2021 •
edited
Loading

Yes, go ahead, + soon any maintainer will assign this to you.

@mohan-murali
Copy link
Contributor

@FidalMathew Oh you are working on this? I actually fixed this one.

@mohan-murali mohan-murali mentioned this issue Nov 1, 2021
Merged
@FidalMathew
Copy link
Member

Sorry, @mohan-murali I didn't check out this message. Thank you for giving me the opportunity to contribute.

@schmelto schmelto added 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) labels Nov 1, 2021
@Pradumnasaraf
Copy link
Contributor Author

@FidalMathew Oh you are working on this? I actually fixed this one.

So you didn't open the PR after fixing @mohan-murali ?

@mohan-murali
Copy link
Contributor

@FidalMathew Oh you are working on this? I actually fixed this one.

So you didn't open the PR after fixing @mohan-murali ?

No I was going to, but it was taken. And I checked that @FidalMathew had already raised PR. Its fine. As long as it fixes the issue. :)

@Pradumnasaraf
Copy link
Contributor Author

Pradumnasaraf commented Nov 1, 2021 •
edited
Loading

Oh, I see, still thanks for the effort @mohan-murali

Just advice - if you find some Open issues, and you feel like you gonna work on it, before start working on that, drop a message below on the issue like I'm working on this/or get assigned.

@Pradumnasaraf Pradumnasaraf reopened this Nov 1, 2021
@Pradumnasaraf
Copy link
Contributor Author

Pradumnasaraf commented Nov 1, 2021 •
edited
Loading

Sorry, I closed it by mistake,
I have reopened it

Vyvy-vi pushed a commit that referenced this issue Nov 1, 2021
@FidalMathew
fix: center user-list (#620)
f044703 
* center-users

* Center users via PrimeReact

* center placeholder
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mohan-murali mohan-murali

Labels
🛠 goal: fix undefined 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

center-users FidalMathew/LinkFree
4 participants
@mohan-murali @schmelto @Pradumnasaraf @FidalMathew