Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Add Default Profile Image #667

Closed
AbhinavMV opened this issue Nov 14, 2021 · 9 comments · Fixed by #682
Closed

Add Default Profile Image #667

AbhinavMV opened this issue Nov 14, 2021 · 9 comments · Fixed by #682
Assignees
@harshrai654
Labels
🛠 goal: fix undefined

Comments

@AbhinavMV
Copy link
Contributor

Description

If an image is not visible we can show a default image with Initial character from name (eg: Like it is shown on gmail)

Screenshots

image
image

Additional information

No response
@AbhinavMV AbhinavMV added the 🛠 goal: fix undefined label Nov 14, 2021
@github-actions
Copy link
Contributor

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@AbhinavMV AbhinavMV changed the title [Fix]: Add Default Profile Image Add Default Profile Image Nov 14, 2021
@PritamReddy101
Copy link

I would love to give this a try! Can i work on this issue?

@gptkrsh
Copy link
Contributor

gptkrsh commented Nov 17, 2021

I would love to give this a try! Can i work on this issue?

sure :D

@harshrai654 harshrai654 mentioned this issue Nov 19, 2021
Merged
@EmmaDawsonDev
Copy link
Member

Since the avatar is right next to the name I don’t think that initials are necessary. A default profile icon should suffice for all missing profile images.

@harshrai654
Copy link
Contributor

I would love to give this a try! Can i work on this issue?

Are you working on this issue?

@PritamReddy101
Copy link

No I'm not, Sorry. Could you please assign this issue to someone else.

@EmmaDawsonDev
Copy link
Member

Thanks for letting us know @PritamReddy101 . Do you want it assigned to you @harshrai654 ?

@harshrai654
Copy link
Contributor

Thanks for letting us know @PritamReddy101 . Do you want it assigned to you @harshrai654 ?

Yeah sure.

@harshrai654
Copy link
Contributor

@emmalearnscode can you review the changes.

Vyvy-vi pushed a commit that referenced this issue Dec 2, 2021
@harshrai654
feat: Name Initials as avatar fallback (#682)
b86684a 
* Name Initials SVG avatar for errorneous image

* Name Initials SVG on profile page

* removed user profile json file

* Update src/Components/Home/Users.js

* Update src/Components/Profile.js

* moved default SVG behaviour to src/utils.js

* chore: fix packagelock

* using avatar label prop instread of dicebear in Profile.js

* Dicebear API to fetch default profile image

* removed async from setDefaultSVG function

* reset package.json

Co-authored-by: Harsh <harshrai456@gmail.com>
Co-authored-by: Krish Gupta <krishguptadev@outlook.com>

partially resolves #667
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@harshrai654 harshrai654

Labels
🛠 goal: fix undefined
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Name Initials as avatar for cases where image does not exist (fixes #667) harshrai654/LinkFree
5 participants
@AbhinavMV @EmmaDawsonDev @PritamReddy101 @harshrai654 @gptkrsh