Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: icons in all profiles #694

Merged
merged 1 commit into from
Nov 23, 2021
Merged

fix: icons in all profiles #694

merged 1 commit into from
Nov 23, 2021

Conversation

Panquesito7
Copy link
Member

@Panquesito7 Panquesito7 commented Nov 23, 2021

Fixes Issue

Closes #693.

Changes proposed

  • Fix icons in all profiles.

Check List (Check all the boxes which are applicable)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Co-authored-by: Anirudh Anup <anirudh012009@gmail.com>
@Panquesito7 Panquesito7 added the 🛠 goal: fix undefined label Nov 23, 2021
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Copy link
Member

@qwel-exe qwel-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Manidhiraj
Copy link

Manidhiraj commented Nov 23, 2021

#{
"name": "Dhiraj Mani Tiwari,
"bio": "I am a software Developer from India. I am always open to collaborating on projects",
"avatar": "https://github.com/Manidhiraj.png",
"links": [
{
"name": "Follow me on github",
"url": "https://github.com/Manidhiraj",
"icon": "github"
},
{
"name": "Follow me on Linkedin",
"url": "www.linkedin.com/in/dhiraj19101",
"icon": "Linkedin"
}
]
}

@gptkrsh
Copy link
Contributor

gptkrsh commented Nov 23, 2021

#{ "name": "Dhiraj Mani Tiwari, "bio": "I am a software Developer from India. I am always open to collaborating on projects", "links": [ { "name": "Follow me on github", "url": "https://github.com/Manidhiraj", "icon": "github" }, { "name": "Follow me on Linkedin", "url": "www.linkedin.com/in/dhiraj19101", "icon": "Linkedin" } ] }

hmm.

@thepranaygupta
Copy link
Contributor

#{ "name": "Dhiraj Mani Tiwari, "bio": "I am a software Developer from India. I am always open to collaborating on projects", "links": [ { "name": "Follow me on github", "url": "https://github.com/Manidhiraj", "icon": "github" }, { "name": "Follow me on Linkedin", "url": "www.linkedin.com/in/dhiraj19101", "icon": "Linkedin" } ] }

@Manidhiraj please read this

Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohan-murali
Copy link
Contributor

Wow that seems like a lot of work man. Well Done!

@Panquesito7 Panquesito7 merged commit b8a3dca into main Nov 23, 2021
@Panquesito7 Panquesito7 deleted the fix_profiles_icons branch November 23, 2021 17:52
@Panquesito7 Panquesito7 mentioned this pull request Nov 24, 2021
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Icon
9 participants