Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: Use HTTPs links instead of HTTP #700

Merged
merged 1 commit into from
Nov 24, 2021
Merged

fix: Use HTTPs links instead of HTTP #700

merged 1 commit into from
Nov 24, 2021

Conversation

Panquesito7
Copy link
Member

@Panquesito7 Panquesito7 commented Nov 24, 2021

Changes proposed

  • Use HTTPs links instead of HTTP.
    • Do let me know if all links work properly (except those like GitHub/Twitter). 😄

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

@Panquesito7 Panquesito7 added the 🛠 goal: fix undefined label Nov 24, 2021
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Copy link
Member

@EmmaDawsonDev EmmaDawsonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the package-lock file from the PR?

Contributing.md Outdated Show resolved Hide resolved
@Panquesito7
Copy link
Member Author

Can you remove the package-lock file from the PR?

By the way, I think that file should be updated in a PR or commit. 😅

@Panquesito7 Panquesito7 merged commit 2ea6716 into main Nov 24, 2021
@Panquesito7 Panquesito7 deleted the https_links branch November 24, 2021 23:26
Copy link
Contributor

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But I believe this could be a docs: commit and didn't need a version bump

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants