Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: add donlouie #742

Merged
merged 3 commits into from
Nov 29, 2021
Merged

fix: add donlouie #742

merged 3 commits into from
Nov 29, 2021

Conversation

donlouie
Copy link
Contributor

@donlouie donlouie commented Nov 28, 2021

[x] - add profile donlouie.json

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Copy link
Member

@Vyvy-vi Vyvy-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, however, this file needs formatting...

It would be great if it can be changed to -

{
  "name": "Louie",
  "bio": "Web Developer, Exploring Open Source",
  "avatar": "https://github.com/donlouie.png",
  "links": [
    {
      "name": "Follow me on GitHub",
      "url": "https://github.com/donlouie",
      "icon": "github"
    }
  ]
}

@Panquesito7 Panquesito7 added the ✍ chore: profile This label will be added on PR with request of Data json addition label Nov 28, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments above.

@Panquesito7 Panquesito7 changed the title add donlouie fix: add donlouie Nov 29, 2021
Copy link
Contributor Author

@donlouie donlouie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go?

Co-authored-by: David Leal <halfpacho@gmail.com>
@Panquesito7 Panquesito7 merged commit 655a255 into EddieHubCommunity:main Nov 29, 2021
Copy link
Contributor

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants