Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: add Anish Lohiya to the list #859

Merged
merged 9 commits into from
Dec 26, 2021

Conversation

AnishLohiya
Copy link
Contributor

@AnishLohiya AnishLohiya commented Dec 25, 2021

Fixes Issue

Changes proposed

Added AnishLohiya Profile

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Sorry, something went wrong.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@Panquesito7 Panquesito7 added the ✍ chore: profile This label will be added on PR with request of Data json addition label Dec 26, 2021
@Panquesito7 Panquesito7 changed the title Add AnishLohiya profile fix: add Anish Lohiya to the list Dec 26, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Please revert the changes in the package-lock.json and package.json files. Let us know if you need any help! :)

"lockfileVersion": 2,
"requires": true,
"packages": {
"": {
"name": "linkfree",
"version": "0.54.1",
"version": "0.54.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "0.54.4",
"version": "0.54.1",

@@ -1,12 +1,12 @@
{
"name": "linkfree",
"version": "0.54.1",
"version": "0.54.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "0.54.4",
"version": "0.54.1",

Copy link
Contributor

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the endline in package.json

Copy link
Member

@syedsohan syedsohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an endline after line number 18!

Copy link
Member

@syedsohan syedsohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Co-authored-by: Krish Gupta <krishguptadev@outlook.com>
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

@Panquesito7 Panquesito7 merged commit 93b7d47 into EddieHubCommunity:main Dec 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants