Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: Failing to add repo with trailing slash #8636

Merged
merged 5 commits into from
Aug 14, 2023

Conversation

SaptarshiSarkar12
Copy link
Member

@SaptarshiSarkar12 SaptarshiSarkar12 commented Aug 13, 2023

Fixes Issue

Fixes #8560

Changes proposed

I have made the following changes :

  • I added a condition in the repo.js file in the api/account/manage directory, to check if the url entered by the user contains a trailing slash. If it contains, then the url will be changed to the one without the trailing slash before the GitHub API call is made, without changing the url in the text box placeholder. So, the user does not get to know about the issue with the trailing slash.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

See the below video recording of the fix implemented via this PR.

Screencast.from.2023-08-13.19-50-44.webm

@github-actions github-actions bot added the issue linked Pull Request has issue linked label Aug 13, 2023
@known-samy
Copy link

done

@badrivlog
Copy link
Contributor

Looks Good 👍

@SaptarshiSarkar12
Copy link
Member Author

Looks Good 👍

Thank you for reviewing @badrivlog 😄 !

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@eddiejaoude eddiejaoude merged commit d337de3 into EddieHubCommunity:main Aug 14, 2023
@SaptarshiSarkar12
Copy link
Member Author

Thank you @eddiejaoude for the merge 😄 🎉 !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue linked Pull Request has issue linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Failed to add Github Repo
5 participants