Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Is this a bit too spammy? (It's great having you contribute to this project) #61

Open
stemount opened this issue Jan 26, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@stemount
Copy link
Member

stemount commented Jan 26, 2021

Opening a new issue as a seasoned EddieHub contributor/mod/whatever... it seems quite counterproductive to always respond with a thanks - especially as I imagine this creates more notifications but I could be totally wrong here!

Maybe it can fire off once for a new member who has contributed to an issue or even created their first issue then never fire off again?

@github-actions
Copy link

It's great having you contribute to this project

Welcome to the community 🤓 If any questions please ask

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@naomi-lgbt
Copy link

This actually wouldn't be too difficult to implement within the action.

@eddiejaoude
Copy link
Member

This is a good idea. Here is an example https://github.com/JJ/issue-greeting-action/blob/master/src/main.ts#L56

async function isFirstIssue(
  client: github.GitHub,
  owner: string,
  repo: string,
  sender: string,
  curIssueNumber: number
): Promise<boolean> {
  const {status, data: issues} = await client.issues.listForRepo({
    owner: owner,
    repo: repo,
    creator: sender,
    state: 'all'
  });

  if (status !== 200) {
    throw new Error(`Received unexpected API status code ${status}`);
  }

  if (issues.length === 0) {
    return true;
  }

  for (const issue of issues) {
    if (issue.number < curIssueNumber && !issue.pull_request) {
      return false;
    }
  }

  return true;
}

@eddiejaoude eddiejaoude added the enhancement New feature or request label Feb 2, 2021
@indiehjaerta
Copy link

Would be great if it was first time or you could exclude usernames like dependabot f.ex.

@eddiejaoude
Copy link
Member

We are using another Action to do the greeting now, so hopefully it is better

@LoneDev6
Copy link

Yup! I don't want to receive notifications for issues I create myself

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants