Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

fix: Remove the firebase key part #80

Merged
merged 1 commit into from
Dec 11, 2021
Merged

fix: Remove the firebase key part #80

merged 1 commit into from
Dec 11, 2021

Conversation

Panquesito7
Copy link
Member

Things added/changed:

  • Remove the firebase key part.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Copy link

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just add a comment that reminds us that the firebase part has to be replaced by the API

Copy link

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'll take time to change, thus approving. RR: @schmelto @eddiejaoude

@eddiejaoude eddiejaoude merged commit 219b9c5 into EddieHubCommunity:develop Dec 11, 2021
@eddiejaoude
Copy link
Member

Thanks all 👍

@Panquesito7 Panquesito7 deleted the remove_firebase branch December 11, 2021 05:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants