Paul/est dex #320
Paul/est dex #320
Conversation
paullinator
force-pushed
the
paul/estDex
branch
from
1099617 to
16269c7
Compare
Use hex not text and use newer memos field
paullinator
force-pushed
the
paul/estDex
branch
from
16269c7 to
ab7d0f9
Compare
There was a problem hiding this comment.
In commit 3888e40 it looks like we change some constants and config, but I don't see where the API call change happened. Could you point that out in a review-bar?
Otherwise, the rest of my feedback are to add more comments to the code to resolve questions.
| // const lk = await account.getLoginKey() | ||
| // console.log(`Login key: ${lk}`) |
There was a problem hiding this comment.
I left that in there since if you want a real account to login quickly, you'll want to get the loginKey and uncommenting those lines is how you get it
There was a problem hiding this comment.
Add a comment similar to this then:
// if you want a real account to login quickly, you'll want to get the loginKey and uncommenting those lines is how you get it| await ethWallet.changePaused(false) | ||
| await avaxWallet.changePaused(false) |
There was a problem hiding this comment.
Why are these wallets un-paused? Comment?
There was a problem hiding this comment.
Wallets are now paused by default so you have to unpause them to use them.
There was a problem hiding this comment.
Should this be an argument to the CLI? (optional)
|
/rebase |
github-actions
bot
force-pushed
the
paul/estDex
branch
from
11374b4 to
6186dc6
Compare
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none