Rewrite EOS handle scene #4352
Merged
Rewrite EOS handle scene #4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/rewrite-eos-handle-scene
branch
from
896076b
to
6a5f249
Compare
|
|
|
|
swansontec
force-pushed
the
william/rewrite-eos-handle-scene
branch
2 times, most recently
from
98603ae
to
67dee1d
Compare
Jon-edge
requested changes
Jul 24, 2023
| type="primary" | ||
| onPress={handleSubmit} | ||
| /> | ||
| <View style={{ paddingBottom: 400 }} /> |
There was a problem hiding this comment.
This hard-coded padding allows you to scroll the scene for no reason, especially apparent when the keyboard is collapsed.
The MainButton ought to be stuck to the bottom of the screen or top of the keyboard, keeping aligned with most of our button layouts.
There was a problem hiding this comment.
However, this isn't possible unless we
- Disable scroll in the SceneWrapper or
- Implement content size aware (dynamic scroll enable/disable) SceneWrapper or
- Some other trick I never figured out
I'm fine punting this detail until we do 2
Jon-edge
requested changes
Jul 24, 2023
4 tasks
Jon-edge
approved these changes
Jul 24, 2023
Jon-edge
force-pushed
the
william/rewrite-eos-handle-scene
branch
from
e2dae16
to
b88829a
Compare
swansontec
force-pushed
the
william/rewrite-eos-handle-scene
branch
from
b88829a
to
db86daa
Compare
swansontec
force-pushed
the
william/rewrite-eos-handle-scene
branch
from
db86daa
to
fcc0610
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: