Paul/xrp dex #4386
Merged
Paul/xrp dex #4386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
requested changes
Aug 11, 2023
| @@ -97,6 +98,22 @@ export class CryptoExchangeQuoteScreenComponent extends React.Component<Props, S | |||
| )) | |||
| } | |||
|
|
|||
| showExplanationForCanBePartial = async () => { | |||
There was a problem hiding this comment.
This method name needs to start with handle to satisfy a lint rule we plan to enable one day. Maybe handleCanBePartialExplanation
There was a problem hiding this comment.
This was to be consistent with other handler showExplanationForEstimate
I'll fix with a cleanup to the other handler as well
src/locales/en_US.ts
Outdated
| @@ -785,6 +785,12 @@ const strings = { | |||
| edge_login_fail_message: 'Could not connect to network. Please check your network connection and try again.', | |||
| edge_login_fetching: 'Fetching Edge Login info...', | |||
| modal_addressexplorer_message: 'Show Address in Block Explorer?', | |||
| can_be_partial_quote: 'Maybe Partial Quote', | |||
There was a problem hiding this comment.
The string name should have _title on the end, per a previous sidebar. I also think we should drop the word "Maybe", since that's included in the explanation below.
There was a problem hiding this comment.
This was also to be consistent with estimated_exchange_rate but that's the a fair catch. I'll change to adhere to new standards
paullinator
force-pushed
the
paul/xrpDex
branch
from
de10f0f
to
aefb6d6
Compare
swansontec
approved these changes
Aug 14, 2023
|
/rebase |
github-actions
bot
force-pushed
the
paul/xrpDex
branch
from
aefb6d6
to
73c4f24
Compare
- Set hasTabs - FIx margins
paullinator
force-pushed
the
paul/xrpDex
branch
from
73c4f24
to
17d1c03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
added: XRP DEX support
fixed: Exchange quote layout spacing
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: