Paul/bitwave csv

[paullinator]

CHANGELOG

added: Export Bitwave format CSV

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

• Tested on iOS device
• Tested on Android device
• Tested on small-screen device (iPod Touch)
• Tested on large-screen device (tablet)

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1205274123045129

[swansontec]

The export logic is simple enough, but there is a problem with the toggle switches on Android.

[swansontec]

The Android toggles are messed up. We need to do the following:

  handleQboToggle = () => {
    if (android) {
      this.setState({ isExportQbo: true, isExportCsv: false, isExportBitwave: false })
   } else { 
     this.setState(state => ({ isExportQbo: !state.isExportQbo }))
   }
  }

And likewise for the other 2 handlers. Then in the renderAndroidSwitches, we use these 3 handlers, instead of the generic handleAndroidToggle.

This is because Android can only choose one option at a time. With two options, it doesn't really matter which is which, but with 3 options, it suddenly matters which switch you choose, so we need separate handlers.

[paullinator]

good catch. will do.

[swansontec]

It's closer, and we could merge it if we really had to, but I see a way the user could crash it.

[swansontec]

If you press the radio button once on Android, it will select the option. If the press the ratio button again, it will de-select the option and leave nothing chosen. Then, when you hit submit, you will get a crash, because files[0] is undefined.

The way I wrote the handler in my original review comment would have avoided this possibility, by ensuring exactly one item can be selected on Android.

[paullinator]

You can't submit if nothing is selected. The Next button is hidden. This is also true on iOS. I did test this case. But it's fair to say the user shouldn't be allowed to select nothing. Admittedly I was trying to keep the logic similar to iOS wrt allowing a deselection

[paullinator]

/rebase