Paul/edge provider extra tab #4409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
requested changes
Aug 28, 2023
src/types/types.ts
Outdated
| @@ -308,6 +308,7 @@ export interface AppConfig { | |||
| website: string | |||
| extraTab?: { | |||
| webviewUrl: string | |||
| useEdgeProvider: boolean | |||
There was a problem hiding this comment.
This naming conflicts with hooks naming convention useXyz. Perhaps to avoid confusion, could we name it tabType: 'provider' | 'webview'?
There was a problem hiding this comment.
will use tabType: 'edgeProvider' | 'webview'
paullinator
force-pushed
the
paul/edgeProviderExtraTab
branch
from
3b46860
to
99d480f
Compare
samholmes
approved these changes
Aug 29, 2023
|
/rebase |
github-actions
bot
force-pushed
the
paul/edgeProviderExtraTab
branch
from
99d480f
to
83c4178
Compare
paullinator
force-pushed
the
paul/edgeProviderExtraTab
branch
from
83c4178
to
1d15213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
noneDependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: