Jon/post-install-survey #5091
Jon/post-install-survey #5091
Conversation
| @@ -12,6 +12,8 @@ import { ModalUi4 } from '../ui4/ModalUi4' | |||
| export interface ButtonInfo { | |||
| label: string | |||
|
|
|||
| disabled?: boolean | |||
There was a problem hiding this comment.
The buttons modal is for getting simple yes / no style questions. If you need more complicated interactions, you need to build your own modal. It's not complicated.
Jon, you of all people should understand this. You have been campaigning for re-usable components that are designed for a single purpose (ModalFilledTextInput comes to mind). You have also been fighting against cheap hacks, encouraging us to build the right thing instead of re-purposing some existing UI that happens to be "close enough".
Since this modal features more user interaction that simply pressing a button, you should not use the ButtonsModal for this job. That's not what it's for. Instead, we have reusable buttons components, reusable text components, and a reusable modal body specifically to make building custom modal quick & easy. Just use those.
| @@ -40,6 +42,9 @@ export interface ButtonModalProps<Buttons> { | |||
| /** @deprecated. Does nothing. */ | |||
| // eslint-disable-next-line react/no-unused-prop-types | |||
| closeArrow?: boolean | |||
|
|
|||
| /** Called when modal is dismissed */ | |||
| onCancel?: () => void | Promise<void> | |||
Jon-edge
force-pushed
the
jon/post-install-survey
branch
7 times, most recently
from
151a9eb
to
4fe6c5e
Compare
|
Other changes:
|
Jon-edge
force-pushed
the
jon/post-install-survey
branch
2 times, most recently
from
48cbe93
to
4b169e2
Compare
Jon-edge
force-pushed
the
jon/post-install-survey
branch
from
4b169e2
to
0d0d449
Compare
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-login-ui-rn#193
Requirements
If you have made any visual changes to the GUI. Make sure you have: