Paul/promo code #5095
Merged
Paul/promo code #5095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
force-pushed
the
paul/promoCode
branch
from
d26c60a
to
4a160bb
Compare
Jon-edge
force-pushed
the
paul/promoCode
branch
2 times, most recently
from
dcdea0d
to
3d9a8aa
Compare
Jon-edge
reviewed
Jun 14, 2024
| @@ -255,7 +255,7 @@ const strings = { | |||
| wallet_list_add_token: 'Add Token', | |||
| wallet_list_referral_link_currency_invalid: 'Currency to create is invalid', | |||
| wallet_list_referral_link_currency_loading: 'Hang tight. Creating wallet necessary for this promotion', | |||
| wallet_list_referral_link_ask_wallet_creation: 'You need %s wallet for this promotion, do you want to create one?', | |||
| wallet_list_referral_link_ask_wallet_creation_1s: 'You need a %1$s wallet for this promotion. Would you like to create one?', | |||
There was a problem hiding this comment.
Seems better with this wording.
Might as well fix the key, too, since it needs a re-translation.
|
/rebase |
github-actions
bot
force-pushed
the
paul/promoCode
branch
from
3d9a8aa
to
a854479
Compare
This should be used instead of currencyCode going forward
paullinator
force-pushed
the
paul/promoCode
branch
from
a854479
to
70e6d22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: