Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origins with multiple abilities activate all of them on using Primary Ability keybind #357

Closed
BlackjackMKV opened this issue Aug 16, 2023 · 10 comments

Comments

@BlackjackMKV
Copy link

(Created new issue for visibility reasons.)

While ya'll definitely aren't obligated to, I would love to see a backport for 1.18.2 with the issue of all abilities activating on primary ability fixed since there isn't a build for 1.18.2 without this bug. Given the size of it and how popular 1.18.2 is as a version for modding, it would be greatly appreciated.

And, to clarify, I'm not asking for ongoing support for 1.18.2. I don't expect anyone to support an out of date version, of course. Rather, this bug is just massively debilitating to the point that I would love to see at least a single version released for 1.18.2 to fix it. There are a LOT of mods that haven't updated past 1.18.2, which means that a lot of people like my friend group don't have the option to simply update to 1.19+, on top of the many questionable decisions Mojang is making in 1.19.1+ onwards(such as the report system) making it generally not a great idea for even vanilla users to update. Basically, lots of users either can't because of mod issues or won't because of Mojang doing dumb things, and therefore I feel like just one update to fix this issue would be extremely well received.

Originally posted by @BlackjackMKV in #235 (comment)

@BlackjackMKV
Copy link
Author

If that's not something you're willing to do, I entirely understand and you can go ahead and just close the ticket. It would be immensely helpful though!

@MerchantPug
Copy link
Collaborator

I'll probably get around to a major 1.18.2 bugfix at some point in the future as the final version, I'm just wanting to get 1.20.1 out first.

@BlackjackMKV
Copy link
Author

Sounds good! Thanks for the reply! I'll just warn players then about the issue like I have been until that's done. Feel free to take your time as well. I'm just glad to know it'll most likely happen at some point. :)

@Deathwarp6
Copy link

Just curious, how far along is this currently?

@MerchantPug
Copy link
Collaborator

MerchantPug commented Oct 12, 2023

Just curious, how far along is this currently?

Haven't started. 1.18.2 also needs a ton of rewriting, so it's difficult to just do it.

@Deathwarp6
Copy link

I understand, I do some light coding and it's a pain so I can't imagine a mod this vast. Thanks for the feedback though, lets me know the devs care.

@MaverickMartyn
Copy link

I'm so relieved to hear that it's in the works!
I just encountered this bug while building my 1.18.2 pack, and I'm unfortunately stuck on 1.18.2 for numerous reasons.
Thank you for your work! :)

@BlackjackMKV
Copy link
Author

Has this been fixed yet by any chance? It's fine if not, I just thought I'd check in on this since, checking the changelogs in the other versions released since I posted this, I don't see a fix for it yet.

@MerchantPug
Copy link
Collaborator

MerchantPug commented Jan 2, 2024

Has this been fixed yet by any chance? It's fine if not, I just thought I'd check in on this since, checking the changelogs in the other versions released since I posted this, I don't see a fix for it yet.

This is a 1.18.2 change, I've only been working on 1.20 atm.
Keep in mind that I'm doing this as a hobby, and 1.18.2 has many other issues that I'd have to look into before I get to releasing a version, it's honestly kinda overwhelming to have to put all this work into a version of the game that I don't super care about (no offense).

@BlackjackMKV
Copy link
Author

Has this been fixed yet by any chance? It's fine if not, I just thought I'd check in on this since, checking the changelogs in the other versions released since I posted this, I don't see a fix for it yet.

This is a 1.18.2 change, I've only been working on 1.20 atm. Keep in mind that I'm doing this as a hobby, and 1.18.2 has many other issues that I'd have to look into before I get to releasing a version, it's honestly kinda overwhelming to have to put all this work into a version of the game that I don't super care about (no offense).

No worries! As I mentioned earlier, I'm just glad it's even a consideration. If it wasn't for this lovely 1.1984 update that has been banning people for cussing in their own private LAN worlds even, I'd probably be on the latest version anyway. Between that and the fact they've not added anything I particularly care about with WAY more mods on 1.18.2 than on 1.19+, I just haven't wanted to or cared to update. Since it's very much my choice to stay on an out of date version though, I don't expect any continuing support, so I'm just happy you're even considering doing it at all. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants