Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add higher level API to gracefully close connection #20

Open
tebruno99 opened this issue Dec 13, 2022 · 0 comments
Open

Add higher level API to gracefully close connection #20

tebruno99 opened this issue Dec 13, 2022 · 0 comments
Assignees
@tebruno99

Comments

@tebruno99
Copy link

Original Issue: gorilla#448 by markusthoem

See original discussion for understanding & details

It seems like to achieve a "normal" shutdown of a websocket connection, one needs to do a dance like:

Send Close message
Wait for receiving a Close message
Actually close the connection
The Close method of today closes the connection immediately, without warning or graceful shutdown. Would it be desirable to >have a Shutdown method like golang's http servers, which does the dance explained above for the user?
@tebruno99 tebruno99 self-assigned this Dec 13, 2022
@tebruno99 tebruno99 mentioned this issue Dec 13, 2022
Merged
@tebruno99 tebruno99 linked a pull request Dec 13, 2022 that will close this issue
gracefully close connection fixes #21
Merged
@tebruno99 tebruno99 removed a link to a pull request Dec 13, 2022
gracefully close connection fixes #21
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tebruno99 tebruno99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

enhancement/20-add-higher-level-api-to-gracefully-close-connection ElasticPerch/epws
1 participant
@tebruno99