Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations directory contains lots of duplicate .table files #121

Closed
jayvdb opened this issue Jun 26, 2023 · 2 comments · Fixed by #225
Closed

Migrations directory contains lots of duplicate .table files #121

jayvdb opened this issue Jun 26, 2023 · 2 comments · Fixed by #225
Labels
enhancement New feature or request

Comments

@jayvdb
Copy link
Collaborator

jayvdb commented Jun 26, 2023

Each migration directory contains .table files for every model. I suspect it only needs to contain .table files for models that were modified in that migration. The current migration has the current complete set, and a complete set could also be obtained by stepping through the previous migrations back to the initial migration.

@Electron100
Copy link
Owner

That's true, although there's a reasonable bit of refactoring in the migrations logic that would be necessary to do that space optimization. Are you observing a particular problem from the duplicate files, or just observing it as an area for general cleanliness improvement?

@jayvdb
Copy link
Collaborator Author

jayvdb commented Jun 27, 2023

It is just an observation, and not important. Similar to #62 , when these files are being committed and reviewed, if there is lots of unnecessary .table files in a PR it is harder to carefully review the .table files which are modified.

@Electron100 Electron100 added the enhancement New feature or request label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants