Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refurbishing the APBS build and CI process #163

Closed
intendo opened this issue Aug 3, 2021 · 6 comments · Fixed by #171
Closed

Refurbishing the APBS build and CI process #163

intendo opened this issue Aug 3, 2021 · 6 comments · Fixed by #171
Assignees

Comments

@intendo
Copy link
Contributor

intendo commented Aug 3, 2021

Modify top level CMakeLists.txt to replace External Project for building FETK.
Download FETK release compressed files.
Mimic linking in FETK like we do with NanoShaper
Update LIBRARY dependencies and INCLUDE directives.

@nsoblath nsoblath self-assigned this Nov 2, 2021
@nsoblath
Copy link
Collaborator

nsoblath commented Nov 2, 2021

In a major example of scope creep, work on this issue ballooned to include:

  • The FETK changes mentioned above
  • An alternate build for FETK using FetchContent instead of ExternalProject
  • Updating the build systems for geoflow_c and pb_solvers
  • Fixing bugs in geoflow_c and pb_solvers
  • Changing the inclusion of TABI-PB, geoflow-c, and pb_solvers to use FetchContent instead of using ExternalProject
  • Building the APBS version of TABIPBlib within the APBS build (and disabling it within TABI-PB
  • Switching the automatic Windows build to use GitHub Actions instead of AppVeyor
  • Refining all builds (Windows, Mac, Linux) in GitHub Actions and the .build.sh script

@nsoblath nsoblath linked a pull request Nov 2, 2021 that will close this issue
@intendo
Copy link
Contributor Author

intendo commented Nov 2, 2021

Are we ready to remove the Appveyor config and github action?
In other words, do we have a release that works on Windows, MacOS, and Linux?

@nsoblath
Copy link
Collaborator

nsoblath commented Nov 2, 2021

I believe we're ready to remove the AppVeyor config. Actually, I just pushed that change. The GitHub Actions build now works for all three systems.

It'd be worth verifying that the built packages work for end users. Do you have a suggestion of how to do that? Is there a test(s) that could be run just using the built artifacts that would replicate something an end user would do?

@intendo
Copy link
Contributor Author

intendo commented Nov 2, 2021

I added some comments to the PR so that tests can be build and packages built. I think there are Artifacts saved in the Github Actions. We should be able to download each of the Artifacts for Windows, Mac, and Ubuntu and install them and run a few of the examples to see if apbs produces output.

@nsoblath
Copy link
Collaborator

nsoblath commented Nov 3, 2021

I replied to the comments about the testing and packaging. I'll fix the documentation about the Python version too.

I think I have enough information to attempt an application from the examples directory. I'll try implementing a workflow to download the built artifacts and run an example.

@nsoblath nsoblath changed the title Replace FETK in CMake with prebuilt FETK static libraries Refurbishing the APBS build and CI process Nov 29, 2021
@nsoblath
Copy link
Collaborator

Additional change now covered by this issue: iAPBS build, as discussed in #187.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants