plugins: Correct the behavior for validation problems

[qwepoizt]

Expected behavior

1. checker plugins should run their validation during ...Get() and ...Set().
2. If a validation problem occurs during ...Set(), the plugin should set an error and return -1
3. If a validation problem occurs during ...Get(), the plugin should add a warning and continue validation (finally return 0)
4. plugins need to have the placements: pregetstorage and postgetstorage in their metadata. Otherwise ...Get()/...Set() won't be called.

Affected plugins

• glob
• spec
• type
• ipaddr
• email
• network
• path
• unit
• blacklist
• length - see [CM T0] Correct the behavior for length plugin #4312
• conditionals
• date
• mathcheck
• macaddr
• range - fixed via Treat validation problems as warnings in HL API #4063
• reference
• rgbcolor
• validation
• filecheck
• lineendings

Steps to fix the issue

1. Ensure placements are correct (see "Expected behavior" above)
2. Ensure validation is executed during both ...Get() and ...Set()
3. Refactor validation into new method, don't just copy ...Get() to ...Set() or vice versas.
4. Ensure return codes and classification as error/warning is correct (see "Expected behavior" above)

[qwepoizt]

@markus2330 Please feel free to edit the description, if I got something wrong.

[markus2330]

Thank you for creating the issue! The description is very good.

[marvin-the-parrot]

[FLOSS H1]
Checking should be done during both get() and set().

Since there is already one example in refactoring the way in which the validation should be implemented, this solution should be able to be adapted to the different plugins.

As far as i could see all elektra plugins are written in c, because of this i tagged this issue with lang/c is this correct?

[markus2330]

As far as i could see all elektra plugins are written in c, because of this i tagged this issue with lang/c is this correct?

Some are C++. The one validation plugin in Java has its separate issue #4001. There are ruby and python plugins too but iirc they don't do validation.

[github-actions]

I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

[github-actions]

I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue.
Thank you for your contributions 💖