[Bug Report] Conditional Judgment Inadequate

[agamem]

Element UI version

2.12.0

OS/Browsers version

win10

Vue version

2.6.10

Reproduction Link

https://jsfiddle.net/null

Steps to reproduce

null

What is Expected?

null

What is actually happening?

element/packages/table/src/table-layout.js

Line 100 in 45cb58a

const headerTrElm = headerWrapper.querySelector('.el-table__header tr');

当this.showHeader = false, headerWrapper = undefined 时，100行报错
97 if (this.showHeader && !headerWrapper) return;
98
99 // fix issue (#16956)
100 const headerTrElm = headerWrapper.querySelector('.el-table__header tr');
101 const noneHeader = this.headerDisplayNone(headerTrElm);

[element-bot]

Translation of this issue:

Element UI version

2.12.0

OS/Browsers version

Win10

Vue version

2.6.10

Reproduction Link

Https://jsfiddle.net/null

Steps to reproduce

Null

What is Expected?

Null

What is actually happening?

Element/packages/table/src/table-layout.js

Line 100 in 45cb58a
Const headerTrElm = headerWrapper. querySelector ('.el-table__header tr');

When this. showHeader = false, header Wrapper = undefined, 100 lines report errors
97 if (this. show header & & & header Wrapper) return;

Ninety-eight
99// fix issue ()

100 const headerTrElm = headerWrapper. querySelector ('.el-table__header tr');
101 const noneHeader = this. headerDisplayNone (headerTrElm);

[ziyoung]

Issues without a valid reproduction link will be closed directly.

[NavOrange]

<el-table :data="tableData" style="width: 100%" :show-header="false"> <el-table-column fixed prop="date" label="日期" width="180">
https://codepen.io/shuhua95/pen/QWLqwXv

[agamem]

这个issue跟有没有样例有什么关系？
第97行的条件判断，无法保证第100行的headerWrapper是已经被初始化过的。
很明显的逻辑判断不充分啊！

[ziyoung]

这个issue跟有没有样例有什么关系？
第97行的条件判断，无法保证第100行的headerWrapper是已经被初始化过的。
很明显的逻辑判断不充分啊！

@agamem 在 #17341 已经修复了。