Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pset output scalar decoding bug. #1065

Closed
sanket1729 opened this issue Nov 11, 2021 · 1 comment · Fixed by #1121
Closed

Pset output scalar decoding bug. #1065

sanket1729 opened this issue Nov 11, 2021 · 1 comment · Fixed by #1121

Comments

@sanket1729
Copy link
Member

The pset spec says that global scalars PSBT_ELEMENTS_GLOBAL_SCALAR must have value None, but as implemented they have value 0100 (a single vector containing the value zero)

In particular,

SerializeToVector(s, std::vector<unsigned char>());
should directly write 0 instead of SerializeToVector(s, std::vector())

@jgriffiths
Copy link
Contributor

Also, UnserializeFromVector should return immediately if expected_size == 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants