Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Target name #10

Closed
amclain opened this issue Apr 18, 2020 · 3 comments · Fixed by #18
Closed

Question: Target name #10

amclain opened this issue Apr 18, 2020 · 3 comments · Fixed by #18
Assignees
@doughsay

Comments

@amclain
Copy link
Member

amclain commented Apr 18, 2020

Related: #9
Related: 96c4fa8#diff-6023be6004fce4718dad3dafb576d258L6

@doughsay I noticed after PR #9 was merged the hardware target name was changed from keybow to kebow (without the y). Just want to point out that Keybow, the product, does have a y in it. Or are you going for this Kebow? 😜

It just threw me off when building the firmware, so thought I'd point it out. Am I missing something about why the name ended up the way it is now?
@doughsay
Copy link
Member

O. M. G. are you serious? I'm such a dummy! UGH I gotta rename a lot of things now... I guess I got confused because xebow doesn't have the y in it... but then again I made that name up too so maybe I'm just bad at naming things ;)

@amclain
Copy link
Member Author

amclain commented Apr 18, 2020

❤️

This is what peer review is for, right? 😉

@doughsay
Copy link
Member

Fixed in #18

@doughsay doughsay mentioned this issue Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doughsay doughsay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates to the typo fixed system and fixes local typos nerves-keyboard/xebow
2 participants
@doughsay @amclain