Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing --no-spirt (and outdated codepaths) in Rust-GPU 0.8. #1045

Closed
eddyb opened this issue Apr 22, 2023 · 0 comments · Fixed by #1052
Closed

Consider removing --no-spirt (and outdated codepaths) in Rust-GPU 0.8. #1045

eddyb opened this issue Apr 22, 2023 · 0 comments · Fixed by #1052
Assignees
Labels
s: blocked PRs blocked on external factors. t: tracking issue An issue tracking the progress of a specific feature or change.

Comments

@eddyb
Copy link
Contributor

eddyb commented Apr 22, 2023

Timeline so far:

(you can read a lot more in each of those PRs)

The only blocker I can think of, for removing --no-spirt, is an external one:

I would prefer to move over to SPIR-T by default, and not maintain two codepaths (especially with experiments like SPIR-T qptr themselves being opt-in, testing all the configurations is getting cumbersome).

Also, if we fully commit to SPIR-T, it should be possible to move debugging/testing features to SPIR-T, to avoid wasteful steps like re-parsing SPIR-V emitted by spirt::spv::lift back into rspirv (which can be also be lossier around e.g. OpLine), etc.

@eddyb eddyb self-assigned this Apr 22, 2023
@eddyb eddyb changed the title Consider removing --no-spirt (and the old structurizer) in Rust-GPU 0.8. Consider removing --no-spirt (and outdated codepaths) in Rust-GPU 0.8. Apr 22, 2023
@eddyb eddyb added s: blocked PRs blocked on external factors. t: tracking issue An issue tracking the progress of a specific feature or change. labels Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: blocked PRs blocked on external factors. t: tracking issue An issue tracking the progress of a specific feature or change.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant