Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sky shader example has validation eror #247

Closed
fu5ha opened this issue Nov 17, 2020 · 4 comments · Fixed by #295
Closed

sky shader example has validation eror #247

fu5ha opened this issue Nov 17, 2020 · 4 comments · Fixed by #295
Labels
a: examples Issues specific to the examples in the repository. c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. t: bug Something isn't working

Comments

@fu5ha
Copy link
Member

fu5ha commented Nov 17, 2020

Related to #232, push constants when used in a "block" fashion as they are in the sky shader need a Block decoration in spir-v, I guess #232

though it does still work for me, at least on nvidia

@fu5ha fu5ha added t: bug Something isn't working a: examples Issues specific to the examples in the repository. c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. labels Nov 17, 2020
@fu5ha
Copy link
Member Author

fu5ha commented Nov 17, 2020

image

@VZout
Copy link
Member

VZout commented Nov 18, 2020

The dev guide example for uniforms has the same error. And you will likely run into this as well when running ark if you enable validation.

@eddyb
Copy link
Contributor

eddyb commented Nov 24, 2020

SwiftShader uses SPIRV-Tools and that also fails (see #136 (comment)) with:

SPIR-V ERROR: 0:0 PushConstant id '8' is missing Block decoration.
From Vulkan spec, section 14.5.1:
Such variables must be identified with a Block decoration
  %shared__ShaderConstants = OpTypeStruct %uint %uint %float

@eddyb
Copy link
Contributor

eddyb commented Dec 1, 2020

Looks like this is easy to reproduce with:

spirv-val --target-env vulkan1.1 target/spirv-unknown-unknown/release/sky_shader.spv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: examples Issues specific to the examples in the repository. c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. t: bug Something isn't working
Projects
None yet
3 participants