Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to use image operands in asm! #369

Closed
msiglreith opened this issue Jan 8, 2021 · 1 comment
Closed

Unable to use image operands in asm! #369

msiglreith opened this issue Jan 8, 2021 · 1 comment
Labels
a: image Issues related to image operations in SPIR-V. c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. t: bug Something isn't working

Comments

@msiglreith
Copy link
Contributor

Expected Behaviour

rust-gpu allows writing asm code including image operands

Example

%result = OpImageSampleExplicitLod typeof*{0} %sampledImage %coord Lod %lod"

This results in an error currently regarding too many operands as right now only the Lod image operand will be parsed. rspirv doesn't consume the following IdRefs.

Requires changes to rspirv: gfx-rs/rspirv#178
@msiglreith msiglreith added the t: bug Something isn't working label Jan 8, 2021
@msiglreith msiglreith mentioned this issue Jan 12, 2021
Closed
@khyperia khyperia mentioned this issue Jan 13, 2021
Open
@khyperia khyperia changed the title Unable to use image operands Unable to use image operands in asm! Jan 13, 2021
@XAMPPRocky XAMPPRocky added a: image Issues related to image operations in SPIR-V. c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. labels Mar 3, 2021
@msiglreith
Copy link
Contributor Author

Fixed in #418

@rust-gpu-bot rust-gpu-bot mentioned this issue Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: image Issues related to image operations in SPIR-V. c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. t: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix image operands msiglreith/rust-gpu
2 participants
@XAMPPRocky @msiglreith