Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0 mangling support for const generics #642

Closed
ElectronicRU opened this issue Jun 1, 2021 · 1 comment · Fixed by #737
Closed

v0 mangling support for const generics #642

ElectronicRU opened this issue Jun 1, 2021 · 1 comment · Fixed by #737
Assignees
@eddyb
Labels
t: enhancement A new feature or improvement to an existing one.

Comments

@ElectronicRU
Copy link
Contributor

As we're currently using a const generic type parametrized by enums for Image types, v0 mangling cannot be fully supported because it doesn't handle non-basic-type const generic parameters and panics.

Once rust-lang/rust#61486 is implemented, we can switch back to v0 support.
@ElectronicRU ElectronicRU added the t: enhancement A new feature or improvement to an existing one. label Jun 1, 2021
@eddyb eddyb self-assigned this Jul 30, 2021
@eddyb
Copy link
Contributor

eddyb commented Jul 30, 2021

Self-assigned because I've been working on this (see rust-lang/rust#87194).

@eddyb eddyb mentioned this issue Aug 27, 2021
Merged
@eddyb eddyb closed this as completed in #737 Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyb eddyb

Labels
t: enhancement A new feature or improvement to an existing one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustup: update to nightly-2021-08-27 and re-add -Zsymbol-mangling-version=v0. LykenSol/rust-gpu
2 participants
@eddyb @ElectronicRU