Don't crash on enum usage tag #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, throw a warning if multiple enum entries are used and just use the first entry for code gen. Separate r/w enums can be implemented in the future if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10
The SVD spec allows optionally definining two different
enumeratedValuessets by using theusagetag to specify read or write usage. This feature appears to be very rarely used in the wild and thus is not currently supported by svd2nim.At the moment, svd2nim crashes with an exception if the usage tag is encountered. However, patched stm32 SVD files from the embedded rust project appear to use
usagein some cases even if a single enum is defined.As a quick workaround, this PR removes the check for the
usagetag. Instead, throw a warning if multiple enum entries are used and just use the first entry for code gen.Code generation for separate read/write enums can be implemented in the future if anyone actually needs it, please open a new issue.