Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove computed-property.override deprecation #62

Open
tniezurawski opened this issue Aug 23, 2019 · 2 comments
Open

Remove computed-property.override deprecation #62

tniezurawski opened this issue Aug 23, 2019 · 2 comments

Comments

@tniezurawski
Copy link

I see this deprecation since Ember 3.9.0:

DEPRECATION: The <(unknown):ember2859>#options computed property was just overriden. This removes the computed property and replaces it with a plain value, and has been deprecated. If you want this behavior, consider defining a setter which does it manually. [deprecation id: computed-property.override] See https://emberjs.com/deprecations/v3.x#toc_computed-property-override for more details.

I believe the code responsible for that is:

https://github.com/Exelord/ember-custom-actions/blob/fa509a8ab6106624b89363d23eb2895eb6793f64/addon/actions/custom.js#L8-L14

Where you override options computed property:

https://github.com/Exelord/ember-custom-actions/blob/fa509a8ab6106624b89363d23eb2895eb6793f64/addon/actions/action.js#L44-L46

Solution:
I think you should set options value ({}) in the init hook. It seems like computed prop was used here to avoid state leaking.

@Exelord
Copy link
Member

Exelord commented Aug 23, 2019

Yep this is a fix :)

@zyniq82
Copy link

zyniq82 commented Oct 13, 2021

I think this was fixed in #56, so the issue can be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants