-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Probability of Action #4
Comments
This line came directly from the Unity implementation: https://github.com/Unity-Technologies/ml-agents/blob/master/python/unitytrainers/ppo/models.py They have since updated it but the same line is still there. So I suggest you report the issue there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am looking into your code (which is pretty clean and clear by the way) and have a question for a line of code.
In the file PPO/ppo/model.py, line 185
r_theta = probs / (old_probs + 1e-10)
Would it be more accurate to modify it into
r_theta = tf.reduce_prod(probs,axis=-1) / (tf.reduce_prod(old_probs,axis=-1) + 1e-10)
?
The text was updated successfully, but these errors were encountered: