Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNS: add "enabled" boolean to chain struct #33

Closed
gamarin2 opened this issue May 21, 2021 · 3 comments
Closed

CNS: add "enabled" boolean to chain struct #33

gamarin2 opened this issue May 21, 2021 · 3 comments

Comments

@gamarin2
Copy link
Contributor

When adding a new chain to the backend, we must go through a certain number of steps: #12

An entry in the CNS will be created for a chain before it is ready to be used in production and queried from the front-end. Therefore, I propose we add a enabled boolean to the chain struct. enabled will be manually set to true only after all the steps in the process have been properly completed.

Endpoints should only return value of enabled chains. For example, the /balances response should only contain balances of enabled chains.

cc @gsora @clockworkgr @lukitsbrian

@gamarin2 gamarin2 added the MVP label May 21, 2021
@gsora gsora changed the title Add "enabled" boolean to chain struct CNS: add "enabled" boolean to chain struct May 21, 2021
@gsora
Copy link
Contributor

gsora commented May 21, 2021

@gamarin2 the /chains endpoint should list non-enabled chains?

/chain/{chainName} base path should return 404 for chains that are not enabled?

@gamarin2
Copy link
Contributor Author

I think we should work under the assumption that no info about disabled chain should be returned to the front-end

@gsora
Copy link
Contributor

gsora commented May 21, 2021

Implemented in 9295877.

@gsora gsora closed this as completed May 21, 2021
@gsora gsora removed their assignment Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants