Skip to content

Latest commit

 

History

History
80 lines (60 loc) · 5.35 KB

CONTRIBUTING.md

File metadata and controls

80 lines (60 loc) · 5.35 KB
Raw

Contributing

We're always looking for your help to fix bugs and improve the product. Create a pull request and we'll be happy to take a look. Start by reading the Engineering Design. You can find the doxygen generated documentation here.

Proposing new public APIs

ONNX Runtime has a collection of public APIs. Some of these APIs make their way back into the Windows OS. We make compatibility commitments for these APIs and follow a structured process when adding to them. Please use the Feature Request issue template before starting any PRs that affect any of the public APIs.

Process details

Please search the issue tracker for a similar idea first: there may already be an issue you can contribute to.

  1. Create Issue
    To propose a new feature or API please start by filing a new issue in the issue tracker.
    Include as much detail as you have. It's fine if it's not a complete design: just a summary and rationale is a good starting point.

  2. Discussion
    We'll keep the issue open for community discussion until it has been resolved or is deemed no longer relevant. Note that if an issue isn't a high priority or has many open questions then it might stay open for a long time.

  3. Owner Review
    The ONNX Runtime team will review the proposal and either approve or close the issue based on whether it broadly aligns with the Onnx Runtime Roadmap - High Level Goals section and contribution guidelines.

  4. API Review
    If the feature adds new APIs then we'll start an API review. All new public APIs must be reviewed before merging.
    For making changes to the C API refer to guidance here. For making changes to the WinRT API someone from the ONNX Runtime team will work with you.

  5. Implementation

  • A feature can be implemented by you, the ONNX Runtime team, or other community members. Code contributions are greatly appreciated: feel free to work on any reviewed feature you proposed, or choose one in the backlog and send us a PR. If you are new to the project and want to work on an existing issue, we recommend starting with issues that are tagged with “good first issue”. Please let us know in the issue comments if you are actively working on implementing a feature so we can ensure it's assigned to you.
  • Unit tests: New code must be accompanied by unit tests.
  • Documentation and sample updates: If the PR affects any of the documentation or samples then include those updates in the same PR.
  • Build instructions are here.
  • Checkin Procedure: Once a feature is complete and tested according to the contribution guidelines follow these steps:
    • Fork the repo
    • git clone your fork
    • Create feature branch
    • Make and checkin your changes along with unit tests
    • git commit your changes
    • git push origin HEAD
    • To request merge into master, send a pull request from the web ui.
    • Add 'Microsoft/onnxruntime' as a reviewer.
  • Binaries: We periodically produce signed prerelease binaries from the master branch to validate new features and APIs. After the feature has been sufficiently validated as part of a prerelease package we will include it in the next stable binary release.
  • Note: After creating a pull request, you might not see a build getting triggered right away. One of the onnxruntime team members will trigger the build for you.

Coding guidelines

Please see Coding Conventions and Standards

Guidelines for creating a good PR (pull request)

PR Guidelines

Licensing guidelines

This project welcomes contributions and suggestions. Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us the rights to use your contribution. For details, visit https://cla.microsoft.com.

When you submit a pull request, a CLA-bot will automatically determine whether you need to provide a CLA and decorate the PR appropriately (e.g., label, comment). Simply follow the instructions provided by the bot. You will only need to do this once across all repositories using our CLA.

Code of conduct

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Reporting Security Issues

Security issues and bugs should be reported privately, via email, to the Microsoft Security Response Center (MSRC) at secure@microsoft.com. You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Further information, including the MSRC PGP key, can be found in the Security TechCenter.