Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SettingsDialog from Printing Settings Dynamically to Static #97

Closed
EmmaTellblom opened this issue Sep 5, 2024 · 0 comments · Fixed by #177
Closed

Change SettingsDialog from Printing Settings Dynamically to Static #97

EmmaTellblom opened this issue Sep 5, 2024 · 0 comments · Fixed by #177
Assignees
Labels
Improvement It works but could be improved.
Milestone

Comments

@EmmaTellblom
Copy link
Owner

Title

Change SettingsDialog from Printing Settings Dynamically to Static

Description

Currently, the SettingsDialog uses a dynamic method to print settings from the database based on groupID. This approach has proven to be confusing and has led to issues, such as forgetting to add translations for specific settings like "protect screen." To simplify management and avoid such issues, we propose switching to a static method for handling settings.

Problem

  • Dynamic Printing Issues: The current dynamic approach using groupID has resulted in confusion and administrative difficulties.
  • Translation Oversight: Important settings like "protect screen" were missed because of the dynamic handling.

Proposed Solution

  • Manual Handling: Transition to manually handling each setting in the SettingsDialog to simplify administration and make it easier to manage settings and translations.
  • Remove Obsolete Fields: Eliminate the use of groupID, label, and setting_type as they will no longer be needed with the static approach.

Steps to Implement

  1. Update SettingsDialog: Modify the SettingsDialog to handle settings in a static manner.
  2. Remove Dynamic Logic: Remove or refactor the existing code that relies on dynamic groupID handling.
  3. Update Translations: Ensure that all necessary translations are added and correctly displayed with the static settings approach.
  4. Test Changes: Thoroughly test the updated SettingsDialog to ensure all settings are correctly displayed and managed.
  5. Documentation: Update any relevant documentation to reflect the changes in how settings are handled.

Acceptance Criteria

  • The SettingsDialog displays settings statically, without relying on dynamic groupID handling.
  • All settings, including translations, are correctly displayed and managed.
  • Obsolete fields (groupID, label, setting_type) are removed from the codebase.

Additional Notes

  • Ensure that the transition to a static approach does not introduce new issues or confusion.
  • Consider any necessary adjustments to other parts of the application that interact with SettingsDialog.

Please review and provide feedback or additional suggestions for the proposed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement It works but could be improved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants