-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classic raw rule bug #12
Comments
I don't think this parser should worry about raw PHP tags...anything that uses raw php can be updated to use what blade uses:
|
@calebdw I do agree with you , but considering that technically it is possible to still write php inside As much as I hope no one ever need to use this feature, you never know what people get up to out there 😂 🤷♂️ |
I see your point, but at the same time 1) I think it's going to add unnecessary complexity and 2) this a Blade parser and the Blade templating engine does not do anything with raw php. Once you open that can of worms then you would also need to support echo tags ( The best thing would probably be to update the ((html) @injection.content
(#set! injection.combined)
(#set! injection.language html))
; would be
((text) @injection.content
(#set! injection.combined)
(#set! injection.language php)) It's up to you, but I would not support it myself... |
@calebdw That is actually a superb idea!! 🙏 The beauty is we can even go ahead and just do this, while waiting for the split parser. |
merging to #16 |
There is bug that the parser does not pick up
$._classic_raw
The text was updated successfully, but these errors were encountered: