Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to exclude aws-sdk by default #8

Closed
skilledDeveloper opened this issue Nov 7, 2016 · 1 comment
Closed

No need to exclude aws-sdk by default #8

skilledDeveloper opened this issue Nov 7, 2016 · 1 comment

Comments

@skilledDeveloper
Copy link

Since aws-sdk has recently supported browserify, it might be the time to stop excluding it in this plugin.
More info: aws/aws-sdk-js#696

@goncaloneves
Copy link
Contributor

@skilledDeveloper Thanks for bringing this.

From what I read Browserify support is to require individual modules like require('aws-sdk/clients/s3') if you want to use the latest sdk version and not the lambda one.
If this is so, it will depend on the setup and preference. Not having it as default, would require to always setting it up globally and probably this is the majority use case.

Right now we could remove aws-sdk from exclude by setting globally in custom or if we use the functions exclude:

custom:
  optimize:
    exclude: []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants