Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Advanced search modes #194

Open
trustin opened this issue Dec 22, 2021 · 2 comments
Open

[Feature] Advanced search modes #194

trustin opened this issue Dec 22, 2021 · 2 comments
Labels
feature add new feature

Comments

@trustin
Copy link

trustin commented Dec 22, 2021

Hi! Thank you so much for this extremely useful extension. I'm loving it so far. 🙇

One wish I have for this extension is the ability to do filter the file list using a negative lookup. For example, let's say we have the following file tree:

a
- b
  - c
  - d
- e

In a very large tree, I want to exclude everything under a/b. I tried to filter them out by using a regular expression such as (?!b) and (?!a/b), but it doesn't seem to filter out anything.

Would it be possible to add support for negative lookahead/behind regular expressions?

@EnixCoda
Copy link
Owner

Hi @trustin

I can see that you want an advanced search mode. Actually, negative lookahead/behind regular expressions are already supported. However, for now, regular expressions are applied to file/folder names, instead of paths. That is why you got confused. I will update the description of search modes to prevent that.

image
image


And if the regular expressions are applied to paths, there will be no way to highlight results because matched characters of different paths can vary and get users more confused.

For now, I'd suggest manually collapse those folders you'd like to exclude after searching.

We can keep this issue open to see more users need advanced search mode.

@EnixCoda EnixCoda changed the title Negative lookahead/lookbehind regular expressions [Feature] Advanced search modes Dec 25, 2021
@EnixCoda EnixCoda added the feature add new feature label Dec 25, 2021
@EnixCoda
Copy link
Owner

The advanced search mode can be either

  1. simply applying regular expressions to paths
  2. or a more complicated UI with multiple inputs for including and excluding rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature add new feature
Projects
None yet
Development

No branches or pull requests

2 participants