-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(abp1-revert-fix): Fix revert abp1 #620
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 05d5d9e.
jdinh8124
temporarily deployed
to
fix-revert-abp1-kibana
July 2, 2024 16:43 — with
GitHub Actions
Inactive
jdinh8124
temporarily deployed
to
fix-revert-abp1-kibana
July 2, 2024 20:12 — with
GitHub Actions
Inactive
mdial89f
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Approved. If we're reasonably confident there aren't any other impacts and/or padma spot checks for other problems, all good here .. Thanks James
benjaminpaige
approved these changes
Jul 2, 2024
asharonbaltazar
approved these changes
Jul 2, 2024
jdinh8124
temporarily deployed
to
fix-revert-abp1-kibana
July 2, 2024 21:23 — with
GitHub Actions
Inactive
daniel-belcher
approved these changes
Jul 3, 2024
jdinh8124
temporarily deployed
to
fix-revert-abp1-kibana
July 3, 2024 15:15 — with
GitHub Actions
Inactive
🎉 This PR is included in version 1.5.0-val.56 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixed an issue with styling that needed a revert of abp-1 hcd feedback changes. Buttons were requested to have 16px everywhere in mako. This has been changed accordingly without breaking other aspects of the app.
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-28616