Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abp1-revert-fix): Fix revert abp1 #620

Merged
merged 8 commits into from
Jul 3, 2024
Merged

fix(abp1-revert-fix): Fix revert abp1 #620

merged 8 commits into from
Jul 3, 2024

Conversation

jdinh8124
Copy link
Collaborator

@jdinh8124 jdinh8124 commented Jul 2, 2024

Purpose

Fixed an issue with styling that needed a revert of abp-1 hcd feedback changes. Buttons were requested to have 16px everywhere in mako. This has been changed accordingly without breaking other aspects of the app.

Screen Shot 2024-07-02 at 8 47 51 AM

Linked Issues to Close

https://qmacbis.atlassian.net/browse/OY2-28616

@jdinh8124 jdinh8124 requested a review from mdial89f July 2, 2024 15:48
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 16:38 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 16:39 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 16:39 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 16:43 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1-kibana July 2, 2024 16:43 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 16:43 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 16:43 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 20:07 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 20:08 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 20:08 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 20:12 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 20:12 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1-kibana July 2, 2024 20:12 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 20:12 — with GitHub Actions Inactive
Copy link
Contributor

@mdial89f mdial89f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved. If we're reasonably confident there aren't any other impacts and/or padma spot checks for other problems, all good here .. Thanks James

@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 21:11 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 21:11 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 21:11 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 21:18 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 21:19 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 21:19 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 21:23 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1-kibana July 2, 2024 21:23 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 21:23 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 2, 2024 21:23 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 3, 2024 15:10 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 3, 2024 15:11 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 3, 2024 15:11 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 3, 2024 15:15 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 3, 2024 15:15 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 3, 2024 15:15 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1-kibana July 3, 2024 15:15 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 self-assigned this Jul 3, 2024
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 3, 2024 16:26 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 3, 2024 16:26 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 3, 2024 16:30 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 3, 2024 16:30 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 temporarily deployed to fix-revert-abp1 July 3, 2024 16:30 — with GitHub Actions Inactive
@jdinh8124 jdinh8124 merged commit d018454 into master Jul 3, 2024
14 of 15 checks passed
@jdinh8124 jdinh8124 deleted the fix-revert-abp1 branch July 3, 2024 16:36
Copy link
Contributor

github-actions bot commented Jul 3, 2024

🎉 This PR is included in version 1.5.0-val.56 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants