fix(g3-fixes): G3 fixes found by padma in val #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminpaige
approved these changes
Jul 11, 2024
|
🎉 This PR is included in version 1.5.0-val.59 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
There was a problem hiding this comment.
Is text-black correct? The Figma for the other webforms has the text foreground set by default to #212121, or an RGB value of 33, 33, 33, not #000000 black. This color can also be accessed by using the text-foreground class, but it should aslo be coming through as the default. Is this color different for G3? If so, then maybe check with HCD to figure out which one they want.
I've also noticed that there are many places within the webforms where we're using text-black, and if we're really supposed to be using #212121, maybe we need a ticket to go through and make things consistent.
mdial89f
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Working through logic * add testing requests * Update v202401.ts * adjust regex
mdial89f
added a commit
that referenced
this pull request
Jul 23, 2024
* Working through logic * add testing requests * Update v202401.ts * adjust regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
These were the issues Padma found in Val which caused us to circle back and fix these issues.