Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(emails): App K Subsequent Submissions State & CMS #901

Merged
merged 4 commits into from
Dec 9, 2024
Merged

feat(emails): App K Subsequent Submissions State & CMS #901

merged 4 commits into from
Dec 9, 2024

Conversation

andieswift
Copy link
Collaborator

@andieswift andieswift commented Dec 5, 2024 •
edited
Loading

Purpose

  • need to create appK email templates for uploading subsequent documention for both state and cms

Linked Issues to Close

https://jiraent.cms.gov/browse/OY2-30799
Confluence Link

Screenshots

CMS:
Screenshot 2024-12-06 at 9 02 29 AM

State:
Screenshot 2024-12-06 at 9 02 37 AM

Approach

  • added new templates for AppK state & cms
  • updated index.tsx file to have subject and recipients to match confluence
  • converted some template code to components to be reused
  • added minor styling changes across all sub doc templates

Assorted Notes/Considerations/Learning

  • component: SubDocHowToAccess should be used for the text "how to access.."
  • a line break should be used to break up each section

@andieswift andieswift marked this pull request as ready for review December 5, 2024 22:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.06% 5719 / 8048
🔵 Statements 70.49% 6049 / 8581
🔵 Functions 65% 1720 / 2646
🔵 Branches 40.02% 1017 / 2541
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
lib/libs/email/preview/Upload Subsequent Documents/CMS/AppK.tsx 0% 100% 0% 0% 4-20
lib/libs/email/preview/Upload Subsequent Documents/State/AppK.tsx 0% 100% 0% 0% 4-20
Generated in workflow #867 for commit c18c138 by the Vitest Coverage Report Action

@andieswift andieswift temporarily deployed to appk-email2-kibana December 5, 2024 22:37 — with GitHub Actions Inactive
asharonbaltazar
asharonbaltazar approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@asharonbaltazar asharonbaltazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but might require some adjusting

lib/libs/email/content/email-components.tsx Outdated Show resolved Hide resolved
lib/libs/email/content/upload-subsequent-documents/emailTemplates/AppKCMS.tsx Outdated
>
<PackageDetails
details={{
"State or territory": variables.territory,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"State or territory": variables.territory,
"State or Territory": variables.territory,

Dunno if you were by sprint review, but they've asked territory to be capitalized to avoid offending our territories

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see that, but thanks for letting me know! I made this change and I also see you have a PR open for this very thing so I will take a look 👀

@andieswift andieswift temporarily deployed to appk-email2-kibana December 6, 2024 15:07 — with GitHub Actions Inactive
@andieswift andieswift temporarily deployed to appk-email2-kibana December 6, 2024 15:40 — with GitHub Actions Inactive
@andieswift andieswift temporarily deployed to appk-email2-kibana December 9, 2024 15:52 — with GitHub Actions Inactive
@andieswift andieswift merged commit cf1d3d1 into main Dec 9, 2024
13 of 15 checks passed
@andieswift andieswift deleted the appk-email2 branch December 9, 2024 16:25
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.98 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asharonbaltazar asharonbaltazar asharonbaltazar approved these changes

@jdinh8124 jdinh8124 Awaiting requested review from jdinh8124

@benjaminpaige benjaminpaige Awaiting requested review from benjaminpaige

Assignees
No one assigned
Labels
released on @val
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andieswift @asharonbaltazar