Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(faq): Missing formal request for RAI for Medicaid SPA #977

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

tiffanyvu
Copy link
Collaborator

@tiffanyvu tiffanyvu commented Jan 7, 2025

🎫 Linked Ticket

OY2-32019

💬 Description / Notes

How do I submit a Formal Request for Additional Information (RAI) Response for a Medicaid SPA? is missing in the FAQ section.

🛠 Changes

This section has been added in the same order as it is in legacy.

📸 Screenshots / Demo

Screen Shot 2025-01-07 at 8 50 00 AM

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 80.92% 7175 / 8866
🔵 Statements 79.9% 7490 / 9374
🔵 Functions 72.45% 2096 / 2893
🔵 Branches 49% 1352 / 2759
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/features/faq/content/oneMACFAQContent.tsx 63.15% 20% 90.9% 63.15% 282-289
Generated in workflow #1439 for commit 3419918 by the Vitest Coverage Report Action

@@ -511,6 +511,44 @@ export const oneMACFAQContent: FAQContent[] = [
</p>
),
},
{
anchorText: "formal-request-medicaid-spa",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this anchor text be a specific string?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters as long as its a unique string

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I don't think it matters either. Probably should be called something like anchorID but not a big deal.

@tiffanyvu tiffanyvu requested review from tbolt and 13bfrancis January 7, 2025 17:22
Copy link
Collaborator

@13bfrancis 13bfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@tbolt tbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work.

@@ -511,6 +511,44 @@ export const oneMACFAQContent: FAQContent[] = [
</p>
),
},
{
anchorText: "formal-request-medicaid-spa",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I don't think it matters either. Probably should be called something like anchorID but not a big deal.

@tiffanyvu tiffanyvu temporarily deployed to missing-spa-faq-app January 8, 2025 21:07 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to missing-spa-faq-kibana January 8, 2025 21:07 — with GitHub Actions Inactive
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.104 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants