Gets the true monitor resolution of the input source for multi-monitor setups #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r setups where just using Electron's primaryDisplay is not accurate.
Envek
reviewed
Jun 9, 2020
There was a problem hiding this comment.
But we're still using width and height reported by Electron here:
obs-studio-node-example/obsRecorder.js
Lines 146 to 153 in c905341
So we also should redefine displayInfo function:
obs-studio-node-example/obsRecorder.js
Lines 74 to 88 in c905341
|
|
||
| // Properly scale the video scene using the resolution off whatever monitor is used | ||
| // The source width is only available after it is set as an output source | ||
| const realDisplayWidth = osn.Global.getOutputSource(1).source.width; |
There was a problem hiding this comment.
I'm getting undefined from osn.Global.getOutputSource(1) here and everything breaks.
We can access videoSource variable here (which should contain plain desktop capture), but videoSource.width returns 0 for me here. Weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something like this is needed to actually use the true monitor resolution to scale a scene. When there is only one monitor, this doesn't matter much since Electron's
getPrimaryDisplay()will handle that.However, in multi-monitor setups, Electron's displays are not helpful. To get the resolution dimensions, we must wait until after the source is added and then scale the scene accordingly.
Solves #15