Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin][Bug]: Conversion from WikiLinks to MdLinks does not prepend relative path #212

Closed
2 tasks done
HighPriest opened this issue Aug 26, 2023 · 2 comments
Closed
2 tasks done
Assignees
Labels
🐛 Bug Something isn't working 💎 Obsidian Github Publisher Related to the plugin

Comments

@HighPriest
Copy link

Issue validation

  • I checked the issue to prevent duplicate
  • I checked my configurations files and the documentation

Command used

Upload all notes, Refresh published and upload new notes

Plugin version

6.5.0-7

Describe the bug

The WikiLink to MdLink conversion does not include relative path from the source dir, breaking them.
Related to #37 ?
Could be because of lacking share in frontmatter? Related to change #210 ?

How to reproduce ?

No response

Minimal Reproducible Example

[_metadata_:title]:- "index"
[_metadata_:layout]:- "index"
## Motorsport
- Sim Racing Guide
	- Tuning
		- [[0. Car tuning]]
		- [[1. Variables - Slip angle]]
		- [[1. Variables - Tire Load]]
		- [[1. Variables - Tire Temperatures]]
	- First Steps
		- [[Tuning prerequisities]]
		- [[Gear]]
## Programming
- RaspberryPi
	- [[RPi Installation & Config]]
- Windows
	- [[Creating Symbolic Links - Win 10, Powershell 7]]
- [[Building a website (from scratch)]]
- [[GrayLog Install & Config - ARM64 Debian]]
- [[How easy it is to repair modern UEFI boot]]
- [[Install Wireless Driver for Archer T6E on Ubuntu]]
- [[Linux Tricks]]
- [[Linux Vlans]]
- [[Running old motherboards]]

Configuration

{
  "github": {
    "branch": "main",
    "automaticallyMergePR": true,
    "tokenPath": "%configDir%/plugins/%pluginID%/env",
    "api": {
      "tiersForApi": "Github Free/Pro/Team (default)",
      "hostname": ""
    },
    "workflow": {
      "commitMessage": "[PUBLISHER] Merge",
      "name": "update.yml"
    },
    "verifiedRepo": true
  },
  "upload": {
    "behavior": "obsidian",
    "defaultName": "src",
    "rootFolder": "",
    "yamlFolderKey": "",
    "frontmatterTitle": {
      "enable": false,
      "key": "title"
    },
    "replaceTitle": [],
    "replacePath": [
      {
        "regex": "/`Public` ProgrammingBlog",
        "replacement": "/Programming",
        "type": "path"
      },
      {
        "regex": "/`Public` MotorsportBlog",
        "replacement": "/Motorsport",
        "type": "path"
      }
    ],
    "autoclean": {
      "enable": true,
      "excluded": []
    },
    "folderNote": {
      "enable": false,
      "rename": "index.md"
    },
    "metadataExtractorPath": ""
  },
  "conversion": {
    "hardbreak": false,
    "dataview": true,
    "censorText": [],
    "tags": {
      "inline": false,
      "exclude": [],
      "fields": []
    },
    "links": {
      "internal": true,
      "unshared": false,
      "wiki": true,
      "slugify": true
    }
  },
  "embed": {
    "attachments": true,
    "keySendFile": [],
    "notes": false,
    "folder": "src/assets",
    "convertEmbedToLinks": "keep",
    "charConvert": "->"
  }
}

Relevant log output

Here is the resultant file:
- https://github.com/AmunNet/notes/blob/main/src/Index.md
And preview of raw contents:
- https://raw.githubusercontent.com/AmunNet/notes/main/src/Index.md

OS

Windows

Anything else?

No response

Obsidian information

SYSTEM INFO:
	Obsidian version: v1.3.7
	Installer version: v1.3.7
	Operating system: Windows 10 IoT Enterprise LTSC 2021 10.0.19044
	Login status: not logged in
	Insider build toggle: off
	Live preview: on
	Legacy editor: off
	Base theme: dark
	Community theme: none
	Snippets enabled: 0
	Restricted mode: off
	Plugins installed: 6
	Plugins enabled: 5
		1: Simple Embeds v1.14.1
		2: Tasks Calendar Wrapper v0.2.5
		3: Tasks v4.6.0
		4: ReadItLater v0.3.1
		5: Github Publisher v6.5.0-7
@HighPriest HighPriest added 🐛 Bug Something isn't working 💎 Obsidian Github Publisher Related to the plugin labels Aug 26, 2023
@HighPriest
Copy link
Author

Changing "unshared": false to "unshared": true, fixes the links.

@Mara-Li Mara-Li closed this as completed Aug 26, 2023
@Mara-Li
Copy link
Member

Mara-Li commented Aug 26, 2023

Yes, without frontmatter it's not possible to know if the file exist/must exists in the repository. That's why this option is mandatory!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 💎 Obsidian Github Publisher Related to the plugin
Projects
None yet
Development

No branches or pull requests

2 participants